Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ray dataset not handled well post downloading deltas #75

Open
valiantljk opened this issue Feb 9, 2023 · 0 comments
Open

ray dataset not handled well post downloading deltas #75

valiantljk opened this issue Feb 9, 2023 · 0 comments
Assignees
Labels
bug Something isn't working P1 Resolve if not working on P0 (< 2 weeks)

Comments

@valiantljk
Copy link
Collaborator

https://github.com/ray-project/deltacat/blob/main/deltacat/compute/compactor/steps/hash_bucket.py#L121

if storage_type is StorageType.DISTRIBUTED, the returned tables is a distributed ray dataset.
Several changes are needed to deal with a distributed dataset:

  • replace len() with ds.count(), as len() is not an available attribute of ray dataset
  • figure out how to enumerate a ray dataset as 'Dataset' object is not iterable
  • figure out how to avoid memory copy if ray dataset has to be converted into a pa.table, etc.
@valiantljk valiantljk self-assigned this Feb 9, 2023
@valiantljk valiantljk added bug Something isn't working P1 Resolve if not working on P0 (< 2 weeks) labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Resolve if not working on P0 (< 2 weeks)
Projects
None yet
Development

No branches or pull requests

1 participant