Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for blacklisting http:// (or other schemes) #213

Open
cipriancraciun opened this issue Mar 9, 2022 · 2 comments
Open

Add support for blacklisting http:// (or other schemes) #213

cipriancraciun opened this issue Mar 9, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@cipriancraciun
Copy link

Given that today HTTPS is almost mandatory, it would be useful to have an option to report the presence of http:// URLs.

As an extension to this, perhaps add a way to warn the user if other schemes are used, like for example ftp://, slack://, etc.

Perhaps the simplest way to achieve this is to have either:

  • --allow-scheme http --allow-scheme https --alow-scheme ftp --allow-scheme mailto where any scheme not listed is warned;
  • --deny-scheme gopher --deny-scheme gemini where any scheme listed is warned;
  • (obviously combining both --allow-scheme and --deny-scheme makes no sense;)
@raviqqe
Copy link
Owner

raviqqe commented Mar 26, 2022

Currently, we don't support this use case because Muffet is meant to be a link checker but not a general linter. Is it possible for you to use other existing HTML linting tools instead?

@cipriancraciun
Copy link
Author

Is it possible for you to use other existing HTML linting tools instead?

I could definitively use another tool, in fact I have written a small Go tool myself for this use-case.

However, since muffet is able to crawl "live pages" (i.e. over HTTP), I think it would be a better place to implement such compliance checks, instead of an "offline" (i.e. over files). And sometimes, for example with dynamic sites, there is no "offline" checking possibility.


[...] Muffet is meant to be a link checker [...]

And it is exactly for this reason I've mentioned schemes, which are part of links.

I think a site shouldn't just contain "working links" but also "safe(er) links", thus the primary use-case of checking for http:// links.

@raviqqe raviqqe added the enhancement New feature or request label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants