Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text editor showing white-on-white text when opening a file using dark mode without syntax highlighting. #218

Closed
atomflunder opened this issue Apr 23, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@atomflunder
Copy link

atomflunder commented Apr 23, 2022

Describe the bug:
When you use the text editor in dark mode, the text switches from black to white, but the background of the editor stays white, creating white-on-white text which is not readable unless you highlight the text.
Edit: Just checked and This is only the case when not using syntax highlighting.

Version of DietPi-Dashboard: 0.6.0

Nightly or stable: Stable

Version of DietPi: 8.3.1

Device architecture: armv8, exact device is a Raspberry Pi 4 8GB

To Reproduce

  1. Open any file in the file browser
  2. Select dark mode
  3. Turn off syntax highlighting
  4. Text is showing as white on the white background

Error log

Additional context
Here are a few screenshots showing what I mean:
Light mode: https://i.imgur.com/69o9Gy4.png
Dark mode: https://i.imgur.com/GYhjDbU.png
Dark mode (highlighting text): https://i.imgur.com/FJp2yms.png
Dark mode (with syntax highlighting on): https://i.imgur.com/urdEulj.png

Because dark mode was the default after installation I thought (and maybe others too) the editor was not working until I switched to light mode.

@atomflunder atomflunder added the bug Something isn't working label Apr 23, 2022
@atomflunder atomflunder changed the title The text editor showing white-on-white text when opening a file using dark mode. The text editor showing white-on-white text when opening a file using dark mode without syntax highlighting. Apr 23, 2022
@MichaIng
Copy link
Collaborator

I remember the same for the notification text, e.g. update notifications. Some texts need to be excluded from the black => white color change in dark mode, or, probably better, the respective backgrounds made dark as well 🙂.

@ravenclaw900
Copy link
Owner

Fixed. The editor will now be given a dark background if needed with dark mode enabled.

@atomflunder
Copy link
Author

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants