Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add akv keys check on cosign-verifier #1427

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

binbin-li
Copy link
Collaborator

@binbin-li binbin-li commented Apr 30, 2024

Description

What this PR does / why we need it:

AKS test is failing due to trust policy not found error. Root cause is we missed a check on akv keys in verifier-cosign template.

And azure-test.bats would upgrade ratify deployment which might miss the azurekeyvault.keys in the template. https://github.com/binbin-li/ratify/blob/dev/test/bats/azure-test.bats#L29

The aks test is passing on my forked branch.
image

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@0ac4223). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #1427   +/-   ##
======================================
  Coverage       ?   66.79%           
======================================
  Files          ?      116           
  Lines          ?     6030           
  Branches       ?        0           
======================================
  Hits           ?     4028           
  Misses         ?     1619           
  Partials       ?      383           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binbin-li binbin-li changed the title fix: add akv keys check on cosign-verifier [WIP] fix: add akv keys check on cosign-verifier Apr 30, 2024
@binbin-li binbin-li changed the title [WIP] fix: add akv keys check on cosign-verifier fix: add akv keys check on cosign-verifier Apr 30, 2024
Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@akashsinghal akashsinghal enabled auto-merge (squash) April 30, 2024 16:36
@akashsinghal akashsinghal merged commit a884308 into ratify-project:dev Apr 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants