Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch name field in CRDs to type #1285

Closed
1 task
akashsinghal opened this issue Jan 30, 2024 · 4 comments · Fixed by #1779
Closed
1 task

Switch name field in CRDs to type #1285

akashsinghal opened this issue Jan 30, 2024 · 4 comments · Fixed by #1779
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@akashsinghal
Copy link
Collaborator

What would you like to be added?

Ratify has introduced new type field for CLI scenarios of verifier allowing for multiple instances of same verifier with unique config to exist at once. Right now, the type field used in CLI maps to the name field in CRD and the uniquely identifier name in CLI is equivalent to CRDs metadata.name. Moving forward, we should switch name field to type in CRDs.

This will require:

  • introducing Type field to all CRD spec of store, verifier, and policy
  • support both Name and Type field until v2.0
  • update all docs spec to use type and add deprecation warning in spec to name field.

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@akashsinghal akashsinghal added enhancement New feature or request triage Needs investigation labels Jan 30, 2024
@susanshi susanshi added this to the v1.3.0 milestone Aug 1, 2024
@susanshi
Copy link
Collaborator

susanshi commented Aug 1, 2024

Hi @junczhu , we discussed in community meeting. Please help us understand if both property is available now, the plan is to deprecate "name" in ratify v2.0.0

@susanshi susanshi removed the triage Needs investigation label Aug 1, 2024
@junczhu
Copy link
Collaborator

junczhu commented Aug 26, 2024

Hi @junczhu , we discussed in community meeting. Please help us understand if both property is available now, the plan is to deprecate "name" in ratify v2.0.0

Property is currently not available in CRDs, we may need to introducing the Type field as mentioned above

@susanshi
Copy link
Collaborator

not critical for 1.3 , may spill over to 1.4

@junczhu
Copy link
Collaborator

junczhu commented Sep 3, 2024

add related: #1284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants