-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use ::ratatui
instead of ratatui
#54
Conversation
Should this be a breaking change? |
no |
Can you elaborate on why this is not a breaking change? Just trying to understand. Currently, if a macro like this is defined in this crate: #[macro_export]
macro_rules! my_custom_macro {
() => {
foobar::test()
};
} Even if the mod foobar {
pub fn test() -> String {
String::default()
}
}
fn test_function() {
let s = my_custom_macro!();
} i.e. the current behavior is to call functions from the But with this PR, the behavior is to call functions from the So technically this could be breaking, right? |
Technically yes, but this is the opposite of Unicode-width crate mess that wasn't a "breaking change" despite it being a "change that broke things". This is a "breaking change" that "doesn't break anything". There's 19 results in https://github.com/search?q=ratatui_macros&type=code and none of them define a |
A breaking change is when the intended behaviour changes. This PR ensures that the intended behaviour always works. It’s a fix to ensure it actually works as it should. That’s the same of what unicode-width did: ensuring that it does what it should. This PR seems to also include unrelated changes? |
It was refactoring of the tests, I guess that should have gone in a separate PR? |
Not a big deal in this lib. |
## 🤖 New release * `ratatui-macros`: 0.4.1 -> 0.4.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.2](v0.4.1...v0.4.2) - 2024-06-29 ### Added - Use `::ratatui` instead of `ratatui` ([#54](#54)) - Add row! macro ([#52](#52)) ### Other - Update README with row! documentation ([#56](#56)) - Make doc examples shorter by removing duplicate imports ([#55](#55)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR uses
::ratatui
to ensure it doesn't clash with a module namedratatui
in an app, per comment #52 (comment)This PR also refactors some tests.