-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we tests wheels with raster formats? #104
Comments
one potential idea would be to just convert things on-the-fly within the github action using rasterio methods |
@AndrewAnnex yeah, that's the difficult issue at the heart of this, isn't it? Listing available formats doesn't say whether optional variants of those formats (LERC, JXL, etc) have been built. I wonder if GDAL driver metadata does or could could help us? @rouault can the GTiff driver tell us what its compression options are? |
yes, you can call GDALGetMetadataItem(GDALGetDriverByName("GTiff"), GDAL_DMD_CREATIONOPTIONLIST, NULL). |
would be neat to make a new dict expanding on rasterio.drivers.raster_driver_extensions to include the results from that metadata call |
Fiona has some limited capabilities to access driver options (using GDALGetMetadataItem): https://github.com/Toblerity/Fiona/blob/master/fiona/meta.py#L135-L171 Not sure if it is still the case, but if I remember correctly the Metadata was defined by the drivers manually, thus it depends on the driver how accurate the information is. Fiona has also some round-trip tests, that test if data can be written using a driver and then read back again. But due to the slight difference between Fionas data model and GDALs data model these tests are quite messy. |
My preference would be to not add any round-tripping tests with actual data to rasterio-wheels, but to extend rio-env with an option ( |
Should we add a tests step when we create wheels to make sure we do not release wheels that drop supports for some raster format or compression scheme (e.g #94)
I know it might be difficult to test all format but I'm sure we can at least test for those we added specific step for (e.g https://github.com/rasterio/rasterio-wheels/blob/main/config.sh#L258-L270)
example: https://github.com/lambgeo/docker-lambda/blob/master/tests/tests.sh
The text was updated successfully, but these errors were encountered: