Set pcie link speed before unreset, not after #6487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If autonomous speed negotiation is unreliable then brcm_pcie_set_gen() can be used to override/limit this behaviour. However, setting the limit after the linkup poll means the link can temporarily enter a bad speed which may result in link failure. Move the speed setup to just prior to releasing perst_n. Fixes: 0693b42 ("PCI: brcmstb: Split post-link up initialization to brcm_pcie_start_link()") Signed-off-by: Jonathan Bell <[email protected]>
|
Works perfectly, many thanks. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 25, 2024
kernel: Set pcie link speed before unreset, not after See: raspberrypi/linux#6487 kernel: vc4 / HDMI fixes for 6.12 See: raspberrypi/linux#6485
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 25, 2024
kernel: Set pcie link speed before unreset, not after See: raspberrypi/linux#6487 kernel: vc4 / HDMI fixes for 6.12 See: raspberrypi/linux#6485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trial fix for #6484