From 3687701e8d252864f440f91f1aedf8ffd58d6ee6 Mon Sep 17 00:00:00 2001 From: Phil Elwell Date: Mon, 25 Nov 2024 21:51:13 +0000 Subject: [PATCH] misc: rp1-pio: Fix parameter checks wihout client Passing bad parameters to an API call without a pio pointer will cause a NULL pointer exception when the persistent error is set. Guard against that. Signed-off-by: Phil Elwell --- include/linux/pio_rp1.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/pio_rp1.h b/include/linux/pio_rp1.h index dabe7851776dc..0e5cc97a6eb7d 100644 --- a/include/linux/pio_rp1.h +++ b/include/linux/pio_rp1.h @@ -20,7 +20,7 @@ #endif #define bad_params_if(client, test) \ - ({ bool f = (test); if (f) pio_set_error(client, -EINVAL); \ + ({ bool f = (test); if (f && client) pio_set_error(client, -EINVAL); \ if (f && PARAM_WARNINGS_ENABLED) WARN_ON((test)); \ f; })