Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event action_executed can be deserialised to have hide_rule_turn as None #9490

Closed
joejuzl opened this issue Sep 1, 2021 · 0 comments · Fixed by #9491
Closed

Event action_executed can be deserialised to have hide_rule_turn as None #9490

joejuzl opened this issue Sep 1, 2021 · 0 comments · Fixed by #9491
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@joejuzl
Copy link
Contributor

joejuzl commented Sep 1, 2021

Rasa Open Source version

2.8.0

Rasa SDK version

2.8.0

Rasa X version

No response

Python version

3.8

What operating system are you using?

Linux

What happened?

When an rasa-sdk returns an action_executed event it looks like:

{
    "event": "action",
    "name": "action_listen",
    "policy": null,
    "confidence": null,
    "timestamp": null
}

When it is deserialised by rasa, the parameter hide_rule_turn should be False, as that is the default, however it ends up as None.

This causes issues down the line if the event is passed to rasa-x then back to rasa, as it breaks schema validation.

Command / Request

No response

Relevant log output

No response

@joejuzl joejuzl added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Sep 1, 2021
@joejuzl joejuzl self-assigned this Sep 1, 2021
@joejuzl joejuzl closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant