Get rid of model access in rasa.core.test
#9135
Labels
area:rasa-oss 🎡
Anything related to the open source Rasa framework
area:rasa-oss/model-testing
Issues focused around testing models (e.g. via `rasa test`)
effort:atom-squad/2
Label which is used by the Rasa Atom squad to do internal estimation of task sizes.
feature:rasa-3.0/architecture
type:enhancement ✨
Additions of new features or changes to existing ones, should be doable in a single PR
Description of Problem:
The
rasa.core.test
module has several paths where it directly access attributes on theAgent
or even lower. This has the disadvantage that the test code is really tied to the specific model architecture. With the revamp we want to reduce these ties. This will help us to keep the interface ofGraphprocessor
small and explicit and will reduce the amount of breaking things when we start to implement the actual graph.Related implementation proposal page
Currently the following pieces in the code directly access
Agent
stuff which we don't want it to accessActionLimitReached
when we callprocessor.predict_next_action
instead of having a separate method which requires callers to know the logicOverview of the Solution:
I outlined some proposed ways of getting rid of these accesses. Anything else which doesn't require an additional method on the
GraphProcessor
is also fine.Definition of Done:
processor
The text was updated successfully, but these errors were encountered: