Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom SSL context in Rasa OSS #9085

Closed
mvielkind opened this issue Jul 9, 2021 · 2 comments · Fixed by #9118
Closed

Create custom SSL context in Rasa OSS #9085

mvielkind opened this issue Jul 9, 2021 · 2 comments · Fixed by #9118
Assignees
Labels
area:rasa-oss/custom-actions area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@mvielkind
Copy link

Description of Problem:
When an action server is deployed with a custom SSL certificate the necessary CA certificates also need to be available within Rasa OSS.

Definition of Done:

@mvielkind mvielkind added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jul 9, 2021
@joejuzl joejuzl self-assigned this Jul 12, 2021
@joejuzl
Copy link
Contributor

joejuzl commented Jul 13, 2021

So, status so far:

  • I have created a PR (Add ability to point to a certificate in endpoints.yml #9118) that allows a local certificate file to be specified in endpoints.yaml
  • I have tried it locally with test certificates:
    • I started the action server using the generated self-verified certificate.
    • When not supplying the cert to rasa I get exactly the same error as JPMC.
    • When adding the path to the same certificate running a custom action then works.
  • HOWEVER, This is not exactly the same set-up as JPMC:
    • They use some kind of SSL termination between the k8s pods rather than providing a cert to the action server.
    • I don't know exactly what kind of certificate they are using.
    • @matthew @mariana is there a better way to realistically test this?

Also, we are currently in a minor freeze. This means there won't be any minor releases until 3.0 (around October).
This means we will have to release it as a micro, which is not ideal as it's not a bugifx... But as this seems v high prio it's the only option I can think of.

@m-vdb
Copy link
Collaborator

m-vdb commented Jul 23, 2021

@joejuzl can this be closed?

@joejuzl joejuzl closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss/custom-actions area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants