Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure no warnings from default config. #9078

Closed
2 tasks
joejuzl opened this issue Jul 8, 2021 · 2 comments · Fixed by #9693
Closed
2 tasks

Add test to ensure no warnings from default config. #9078

joejuzl opened this issue Jul 8, 2021 · 2 comments · Fixed by #9693
Assignees
Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@joejuzl
Copy link
Contributor

joejuzl commented Jul 8, 2021

The default config should not cause warnings.
Add a test to confirm no warnings are created from the default rasa init when training or loading a model.

Definition of done

  • Ensure that the default config has no warnings for training and loading a trained model
  • Add a test to ensure no warnings from default config
@joejuzl joejuzl added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) area:rasa-oss/cli Issues focused on the rasa command-line-interface labels Jul 8, 2021
@TyDunn
Copy link
Contributor

TyDunn commented Jul 8, 2021

@joejuzl
Copy link
Contributor Author

joejuzl commented Jul 15, 2021

This is also blocked by a warning that will be removed in #8880 (in MemoizationPolicy)

@TyDunn TyDunn assigned joejuzl and unassigned joejuzl Aug 30, 2021
@joejuzl joejuzl removed their assignment Sep 7, 2021
@TyDunn TyDunn assigned joejuzl and alwx and unassigned joejuzl Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
3 participants