Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spaCy 3.1 #9068

Closed
koaning opened this issue Jul 7, 2021 · 7 comments · Fixed by #9284
Closed

Support spaCy 3.1 #9068

koaning opened this issue Jul 7, 2021 · 7 comments · Fixed by #9284
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@koaning
Copy link
Contributor

koaning commented Jul 7, 2021

SpaCy 3.1 just got released and it supports a few new languages and features. It'd make sense for us to update for Rasa 3.0.

@koaning koaning added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jul 7, 2021
@koaning koaning self-assigned this Jul 7, 2021
@koaning
Copy link
Contributor Author

koaning commented Jul 7, 2021

Related: #8882

@TyDunn
Copy link
Contributor

TyDunn commented Aug 5, 2021

@koaning are you working on this?

@koaning
Copy link
Contributor Author

koaning commented Aug 5, 2021

It's on my todo. I figured with all the Rasa 3.0 stuff that's happening it was low priority and best delayed but I can pick it up at a moments notice.

@TyDunn
Copy link
Contributor

TyDunn commented Aug 5, 2021

So you would do it as part of 3.0 or no? We should factor it into the action plan, if you intend to it to be in the release

@koaning
Copy link
Contributor Author

koaning commented Aug 5, 2021

Ah, pardon! I should've been more explicit. Yes!

Let's put it into the release, it shouldn't be too much work. I might be able to wrap it up tomorrow.

Just to confirm, I can push to master, or should I push to one of the 3.0 branches?

@TyDunn
Copy link
Contributor

TyDunn commented Aug 5, 2021

I think you can just push to main but let's double check with @m-vdb

@m-vdb
Copy link
Collaborator

m-vdb commented Aug 5, 2021

yes, push to main!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants