Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate linear_norm as a possible value for model_confidence #9045

Merged
merged 8 commits into from
Jul 6, 2021
Merged

Deprecate linear_norm as a possible value for model_confidence #9045

merged 8 commits into from
Jul 6, 2021

Conversation

dakshvar22
Copy link
Contributor

Proposed changes:

  • Deprecate linear_norm as a possible value for model_confidence.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@dakshvar22 dakshvar22 requested review from a team and aeshky and removed request for a team and aeshky July 6, 2021 11:33
@dakshvar22 dakshvar22 added this to the 2.8 Rasa Open Source milestone Jul 6, 2021
@dakshvar22 dakshvar22 requested a review from erohmensing July 6, 2021 11:55
aeshky
aeshky suggested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@aeshky aeshky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have requested some changes to improve the clarity of the comments.

changelog/9045.removal.md Outdated Show resolved Hide resolved
changelog/9045.removal.md Outdated Show resolved Hide resolved
docs/docs/migration-guide.mdx Outdated Show resolved Hide resolved
rasa/utils/train_utils.py Outdated Show resolved Hide resolved
erohmensing
erohmensing approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

changelog/9045.removal.md Outdated Show resolved Hide resolved
changelog/9045.removal.md Outdated Show resolved Hide resolved
docs/docs/components.mdx Outdated Show resolved Hide resolved
docs/docs/migration-guide.mdx Outdated Show resolved Hide resolved
rasa/utils/train_utils.py Outdated Show resolved Hide resolved
@dakshvar22 dakshvar22 requested a review from aeshky July 6, 2021 12:41
aeshky
aeshky approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@aeshky aeshky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one more suggestion. Looks good otherwise.

changelog/9045.removal.md Outdated Show resolved Hide resolved
docs/docs/migration-guide.mdx Outdated Show resolved Hide resolved
@dakshvar22
Copy link
Contributor Author

@erohmensing @aeshky Thanks for the super quick reviews 🙏

@dakshvar22 dakshvar22 enabled auto-merge (squash) July 6, 2021 12:56
@dakshvar22 dakshvar22 merged commit e62a832 into main Jul 6, 2021
@dakshvar22 dakshvar22 deleted the deprecate_linear_norm branch July 6, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

@aeshky aeshky aeshky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8 Rasa Open Source
Development

Successfully merging this pull request may close these issues.
3 participants
@dakshvar22 @aeshky @erohmensing