Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 Deprecation Warnings: Action TrackerStore deprecations #8874

Closed
1 task
ancalita opened this issue Jun 14, 2021 · 1 comment · Fixed by #9134
Closed
1 task

3.0 Deprecation Warnings: Action TrackerStore deprecations #8874

ancalita opened this issue Jun 14, 2021 · 1 comment · Fixed by #9134
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/tracker-stores Issues focused around the integration of rasa with different tracker stores. maintenance:rasa-3.0/deprecation

Comments

@ancalita
Copy link
Member

Background
These warnings were found in:

  • rasa.core.tracker_store.py:L99
"f""Specifying the `retrieve_events_from_previous_conversation_sessions` ""
f""kwarg for the `{self.__class__.__name__}` class is deprecated and ""
f""will be removed in Rasa Open Source 3.0. ""
f""Please use the `retrieve_full_tracker()` method instead."""
  • rasa.core.tracker_store.py:L269
"f""Found pickled tracker for ""
 f""conversation ID '{sender_id}'. Deserialization of pickled ""
f""trackers is deprecated and will be removed in Rasa Open Source 3.0. Rasa ""
 f""will perform any future save operations of this tracker using json ""
f""serialisation."""

Definition of Done:

  • resolve warnings in 3.0
@ancalita ancalita added area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/tracker-stores Issues focused around the integration of rasa with different tracker stores. labels Jun 14, 2021
@TyDunn TyDunn added this to the 3.0 Rasa Open Source milestone Jun 15, 2021
@joejuzl
Copy link
Contributor

joejuzl commented Jul 15, 2021

Also found this one in DynamoTrackerStore:

    def save(self, tracker: DialogueStateTracker) -> None:
        """Saves the current conversation state."""
        from botocore.exceptions import ClientError

        if self.event_broker:
            self.stream_events(tracker)
        serialized = self.serialise_tracker(tracker)

        try:
            self.db.put_item(Item=serialized)
        except ClientError as e:
            if "Missing the key session_date" in repr(e):
                # the session_date attribute got removed as it was useless
                # old databases will still contain an attribute for it though
                # which we need to set (otherwise we are getting the error we
                # just ran into) this section should be removed in 3.0
                legacy_date = self._retrieve_latest_session_date(tracker.sender_id)

                serialized["session_date"] = legacy_date
                self.db.put_item(Item=serialized)
            else:
                raise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/tracker-stores Issues focused around the integration of rasa with different tracker stores. maintenance:rasa-3.0/deprecation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants