Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0 Deprecation Warning: Remove synchronous EventBroker method implementations #8862

Closed
1 task done
ancalita opened this issue Jun 14, 2021 · 0 comments · Fixed by #9121
Closed
1 task done

3.0 Deprecation Warning: Remove synchronous EventBroker method implementations #8862

ancalita opened this issue Jun 14, 2021 · 0 comments · Fixed by #9121
Assignees
@ancalita
Labels
area:rasa-oss/event-brokers Issues focused around the integration of rasa with different event brokers (such as RabbitMQ/Kafka) area:rasa-oss 🎡 Anything related to the open source Rasa framework maintenance:rasa-3.0/deprecation
Milestone
3.0 Rasa Open Source

Comments

@ancalita
Copy link
Member

ancalita commented Jun 14, 2021 •
edited
Loading

Background
These deprecation warnings were found in:

  • rasa.core.brokers.broker.py:L118
f""The method '{EventBroker.__name__}.{EventBroker.from_endpoint_config.__name__}' ""
f""was changed to be 'async'. Your event broker '{broker_config.type}' ""
f""is currently synchronous. Support for synchronous implementations of ""
f""'{EventBroker.from_endpoint_config.__name__}' will be removed in 3.0.0."""
  • rasa.core.exporter.py:L91 , rasa.core.run.py:L311
f""The method '{EventBroker.__name__}.{EventBroker.close.__name__}' was ""
f""changed to be asynchronous. Please adapt your custom event broker ""
f""accordingly. Support for synchronous implementations will be removed ""
f""in Rasa Open Source 3.0.0."""

Definition of Done:

  • resolve deprecation warning in 3.0
@ancalita ancalita added area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/event-brokers Issues focused around the integration of rasa with different event brokers (such as RabbitMQ/Kafka) labels Jun 14, 2021
@ancalita ancalita changed the title 3.0 Deprecation Warning: Remove synchronous EventBroker method implementations 3.0 Deprecation Warning: Remove synchronous EventBroker method implementations Jun 14, 2021
@TyDunn TyDunn added this to the 3.0 Rasa Open Source milestone Jun 15, 2021
@ancalita ancalita mentioned this issue Jul 14, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancalita ancalita

Labels
area:rasa-oss/event-brokers Issues focused around the integration of rasa with different event brokers (such as RabbitMQ/Kafka) area:rasa-oss 🎡 Anything related to the open source Rasa framework maintenance:rasa-3.0/deprecation
Projects
None yet
Milestone
3.0 Rasa Open Source
Development

Successfully merging a pull request may close this issue.

Remove event broker deprecation warnings RasaHQ/rasa
3 participants
@joejuzl @TyDunn @ancalita