-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pickling exceptions #8704
Pickling exceptions #8704
Conversation
For UnsupportedModelError, and InvalidModelError
docstring copied from `AgentNotReady` class
Another option is to make |
Thanks for submitting a pull request 🚀 @tttthomasssss will take a look at it as soon as possible ✨ |
would appreciate any feedback on this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, apologies this took so long. Thanks very much for submitting this PR.
All looks good codewise - great work 🎸 ! Could you just expand on the purpose of being able to pickle the exceptions in the changelog
? I.e. just a line or two on why this is needed and what use-case it covers.
Appreciate it @tttthomasssss. Certainly, I have added the purpose for making exceptions pickleable. I hope the explanation would suffice, otherwise I could try adding more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks very much for the lightning fast resolution 🚀
Proposed changes:
UnsupportedModelError
andInvalidModelError
I needed to pass exceptions from background processes to be handled in the main process, but it was these exceptions were causing issues during pickling. The fix is easy, and hopefully a better practice especially for a project like rasa which relies on multiprocessing.
Previous error:
Status (please check what you already did):
black
(please check Readme for instructions)