Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RegexEntityExtractor subclass loading #8641

Merged
merged 4 commits into from
May 12, 2021
Merged

Fix RegexEntityExtractor subclass loading #8641

merged 4 commits into from
May 12, 2021

Conversation

Mazyod
Copy link
Contributor

@Mazyod Mazyod commented May 9, 2021

Proposed changes:

  • RegexEntityExtractor load method instantiates the component using the hardcoded class type as oppose to the cls argument, which loses the subclass type. This caused issues when subclassing RegexEntityExtractor.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger sara-tagger requested a review from JustinaPetr May 10, 2021 06:00
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @JustinaPetr will take a look at it as soon as possible ✨

@JustinaPetr JustinaPetr requested a review from wochinge May 10, 2021 09:46
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 💯
Can you please add a changelog and fix the failing tests? (sorry our docstring checks always capture a bit of the surrounding code to make sure we make progress on improving them).

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you! 💯

@wochinge wochinge merged commit 51c48b6 into RasaHQ:main May 12, 2021
@Mazyod Mazyod deleted the bugfix/regex-subclass branch May 12, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants