-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange attention output to have batch dimension on the 0th axis #8591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one small thing in the changelog. ... And you'll have to fix that test for output shapes.
changelog/8591.misc.md
Outdated
@@ -0,0 +1,3 @@ | |||
Tensorflow models now return batch dimension on the first axis and number of layers on the second axis for output array associated with `attention_output` key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key would be attention_weights
, not attention_output
.
Hey @dakshvar22! 👋 To run model regression tests, comment with the Tips 💡: The model regression test will be run on Tips 💡: Every time when you want to change a configuration you should edit the comment with the previous configuration. You can copy this in your comment and customize:
|
/modeltest include:
- dataset: ["Carbon Bot"]
config: ["Sparse + DIET(bow) + ResponseSelector(bow)", "Sparse + DIET(seq) + ResponseSelector(t2t)"] |
The model regression tests have started. It might take a while, please be patient. Used configuration can be found in the comment. |
Commit: 3c1c5d6, The full report is available as an artifact. Dataset:
|
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)