Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.10.x Back-port for Kafka Partition Key Implementation #8429

Merged
merged 3 commits into from
Apr 12, 2021
Merged

1.10.x Back-port for Kafka Partition Key Implementation #8429

merged 3 commits into from
Apr 12, 2021

Conversation

b-quachtran
Copy link
Contributor

@b-quachtran b-quachtran commented Apr 9, 2021 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@b-quachtran b-quachtran requested a review from federicotdn April 9, 2021 21:40
federicotdn
federicotdn approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nothing to add.

@b-quachtran b-quachtran merged commit 1038a4a into 1.10.x Apr 12, 2021
@b-quachtran b-quachtran deleted the kafka-partition-key-1-10-x branch April 12, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicotdn federicotdn federicotdn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-quachtran @federicotdn