Replace ValueError with RasaException in replace_environment_variables function
#8382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancalita
reviewed
Apr 7, 2021
rasa/shared/utils/io.py
Outdated
| @@ -314,7 +315,7 @@ def env_var_constructor(loader, node): | |||
| w for w in expanded_vars.split() if w.startswith("$") and w in value | |||
| ] | |||
| if not_expanded: | |||
| raise ValueError( | |||
| raise RasaException( | |||
| "Error when trying to expand the environment variables" | |||
| " in '{}'. Please make sure to also set these environment" | |||
| " variables: '{}'.".format(value, not_expanded) | |||
There was a problem hiding this comment.
More of a style comment, shouldn't this be updated to a f-string according to Notion code convention ?
ancalita
reviewed
Apr 7, 2021
|
@ancalita I guess it's a leftover. I will remove it :) |
ancalita
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
ValueErrorwithRasaExceptioninreplace_environment_variablesfunction because it's indeed a usage errorread_yamlfunction failing when trying to expand an environment variable which contains a$#8140Status (please check what you already did):
black(please check Readme for instructions)