Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated python-engineio version for compatibility with python-socketio #8343

Merged
merged 11 commits into from
Apr 12, 2021

Conversation

b-quachtran
Copy link
Contributor

@b-quachtran b-quachtran commented Mar 30, 2021

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@b-quachtran b-quachtran requested a review from joejuzl March 30, 2021 19:37
@b-quachtran
Copy link
Contributor Author

@joejuzl The CI tests keep failing and for some reason poetry update is resulting in a ton of changes with that single change to pyproject.toml. Any idea on where I should be looking / trying?

@joejuzl
Copy link
Contributor

joejuzl commented Apr 1, 2021

Hi @b-quachtran - what version of poetry are you using?

@b-quachtran
Copy link
Contributor Author

@joejuzl Ah thanks, I was on the wrong version. Just re-ran poetry update with v1.1.4

@gausie
Copy link
Contributor

gausie commented Apr 12, 2021

This would supersede #8099

@b-quachtran b-quachtran enabled auto-merge April 12, 2021 15:39
@b-quachtran b-quachtran merged commit e25e645 into main Apr 12, 2021
@b-quachtran b-quachtran deleted the python-engine-io-fix branch April 12, 2021 17:18
@tmbo tmbo mentioned this pull request Apr 13, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python-socketio and python-engineio versions are incompatible
3 participants