Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Partition Key Parameter for Kafka Producer #8335

Merged
merged 14 commits into from
Apr 6, 2021
Merged

Conversation

b-quachtran
Copy link
Contributor

@b-quachtran b-quachtran commented Mar 29, 2021

Proposed changes:

  • Added Partition Key Parameter for Kafka Producer

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@b-quachtran
Copy link
Contributor Author

@wochinge Based on some input from Greg and the customer requesting this feature, I've made some changes so that it partitions by sender_id and updated the endpoints parameter to partition_by_sender to reflect this. Lmk if this approach makes sense.

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

docs/docs/event-brokers.mdx Outdated Show resolved Hide resolved
docs/docs/event-brokers.mdx Outdated Show resolved Hide resolved
docs/docs/event-brokers.mdx Outdated Show resolved Hide resolved
changelog/8335.enhancement.md Outdated Show resolved Hide resolved
@b-quachtran b-quachtran merged commit 7f35d07 into main Apr 6, 2021
@b-quachtran b-quachtran deleted the kafka-partition-key branch April 6, 2021 17:23
@b-quachtran b-quachtran restored the kafka-partition-key branch April 9, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants