Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_import_time takes a lot of time #8056

Closed
alwx opened this issue Feb 26, 2021 · 3 comments · Fixed by #8244
Closed

test_import_time takes a lot of time #8056

alwx opened this issue Feb 26, 2021 · 3 comments · Fixed by #8244
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@alwx
Copy link
Contributor

alwx commented Feb 26, 2021

Rasa version: 2.3.1 (used main branch, commit hash: 2574c46e9576607a7b8de39f823ff3e5c01a475c)

Rasa SDK version (if used & relevant): 2.3.1

Rasa X version (if used & relevant):

Python version: 3.7 / 3.8

Operating system (windows, osx, ...): MacOS / Windows

Issue:
tests/import_time.py::test_import_time takes about 1.5-2 minutes on my machine (slower on Windows), and it's one of the most time-consuming tests we have. Partially it's because we run this measurement 15 times and get an average time it takes to import Rasa after 15 attempts.
I doubt it's needed. First of all, we might consider limiting the number of measurements. But even if we don't want to, we need to think of how we actually use this number.

See more details about time measurements: https://docs.google.com/spreadsheets/d/1tDRD0vWaLW91W1wPj5h__dwXuXioRt9aBPYyF1n4MjI/edit#gid=57091041

Definition of done:

  • Set up a separate job
  • Check if it's required
  • Fix it

Command or request that led to error:

pytest tests/import_time.py::test_import_time
@alwx alwx added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Feb 26, 2021
@alwx alwx added the type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. label Feb 26, 2021
@joejuzl joejuzl added the effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Feb 26, 2021
@wochinge
Copy link
Contributor

related #6473

@alwx alwx mentioned this issue Mar 18, 2021
4 tasks
@Mazyod
Copy link
Contributor

Mazyod commented Mar 19, 2021

Importing rasa is very slow, it would be great if the import speed is fixed instead. Even my project's tests are slow because it imports Rasa at the start of each run.

@wochinge
Copy link
Contributor

@Mazyod Thanks for your input. Import time was recently fixed on main. Will be released with 2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants