Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure exchange name in RabbitMQ event broker #7848

Closed
3 tasks
kaustuk opened this issue Jan 30, 2021 · 2 comments · Fixed by #7899
Closed
3 tasks

Ability to configure exchange name in RabbitMQ event broker #7848

kaustuk opened this issue Jan 30, 2021 · 2 comments · Fixed by #7899
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@kaustuk
Copy link
Contributor

kaustuk commented Jan 30, 2021

Description of Problem:

A case where people want to deploy couple of bots with RabbitMQ as event broker. Rather then maintain different different RabbitMQ(pods or as an external service) user decided to have 1 RabbitMQ infra structure and each bot will have different queue name and exchange, to publish and consumer event. As of now, there is no way to configure exchange name because of this even though the queue name is different, exchange name would be same across bots. And message would be publish to all the queue because it's bind to same exchange that is rasa-exchange as per code. Here is the code link

Overview of the Solution:

Added extra parameter of exchange name to be read from endpoints.yml file

Existing event config schema in endpoints.yaml

event_broker:
  type: pika
  url: localhost
  username: username
  password: password
  queues:
    - queue-1

New proposed schema in endpoints.yaml

event_broker:
  type: pika
  url: localhost
  username: username
  password: password
  queues:
    - queue-1
  exchange_name: rasa-exchanges

Examples (if relevant):

Blockers (if relevant):

This might be the blocker when user what to have multi-tenant bot deployment.

Definition of Done:

  • Tests are added
  • Feature described the docs
  • Feature mentioned in the changelog
@kaustuk kaustuk added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Jan 30, 2021
@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀 @amn41 will get back to you about it soon! ✨

@kaustuk kaustuk changed the title Ability to configure exchange name in RabbitMQ Ability to configure exchange name in RabbitMQ event broker Feb 1, 2021
@kaustuk
Copy link
Contributor Author

kaustuk commented Feb 1, 2021

Hi @amn41, what do you think about this, to able to configure the exchange name for rabbitMQ event broker to achieve multi-tenancy in bot deployment?

I would like to contribute to this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants