Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve warning for missing RulePolicy #7520

Merged
merged 4 commits into from
Jan 6, 2021
Merged

improve warning for missing RulePolicy #7520

merged 4 commits into from
Jan 6, 2021

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Dec 11, 2020 •
edited
Loading

Proposed changes:

  • add RulePolicy to log message
  • change info log to warnings as the user can and should do something about it

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from ArjaanBuijk December 11, 2020 10:32
@wochinge
Copy link
Contributor Author

@ArjaanBuijk Do you have time to review this?

@ArjaanBuijk
Copy link
Contributor

@wochinge , I will review this today.

ArjaanBuijk
ArjaanBuijk approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@ArjaanBuijk ArjaanBuijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is all clear and working. I was just wondering if the URL link could be more targeted to the default_actions.

rasa/core/policies/ensemble.py Outdated Show resolved Hide resolved
@wochinge wochinge force-pushed the correct-warning-missing-rule-policy branch from 9ba9275 to 0fefd35 Compare January 4, 2021 09:55
@wochinge wochinge requested a review from a team January 4, 2021 09:55
@wochinge wochinge requested a review from a team as a code owner January 4, 2021 09:55
@wochinge wochinge requested review from Tawakalt and tczekajlo and removed request for a team January 4, 2021 09:55
@wochinge wochinge changed the base branch from master to 2.2.x January 4, 2021 09:55
@rasabot rasabot merged commit f1c0b96 into 2.2.x Jan 6, 2021
@rasabot rasabot deleted the correct-warning-missing-rule-policy branch January 6, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjaanBuijk ArjaanBuijk ArjaanBuijk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @ArjaanBuijk @rasabot