-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Markdown Training & Test Data #7495
Conversation
@@ -32,11 +32,11 @@ def test_converter_filters_correct_files(training_data_file: Text, should_filter | |||
) | |||
|
|||
|
|||
async def test_stories_are_converted(tmpdir: Path): | |||
converted_data_folder = tmpdir / "converted_data" | |||
async def test_stories_are_converted(tmp_path: Path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced tmpdir
as tmpdir
is not a Path
but of type py.path.local
24c1b5c
to
f6925b9
Compare
@edmacovaz @degiz Re Rasa X: This change will lead to warnings in the terminal when using Rasa X with Markdown format. I added switches so that it's possible to suppress them, but the question is whether this actually needed. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot for working on that! 🚀 🚀 🚀
Not putting Approve
because of the docs, I'm not sure if the deprecation is communicated well enough.
I added switches so that it's possible to suppress them, but the question is whether this actually needed
I think yes. The way it's used in this PR makes sense to me, because we def. don't want these deprecation warnings when rasa data convert
is being used.
future deprecation in the Rasa X UI
This will be more tricky for sure. The closest thing we have now are the warning for the inconsistencies in the domain
, and that's a separate endpoint. Probably will have to do something similar with the training data.
Sorry, I meant if we should use the switches when reading data within Rasa X (e.g. for Integrated Version Control). The deprecation warnings would "only" show up in the server logs which means that only developer can see them. If we use the switches in Rasa X we also have to consider that users might use Rasa X with older Rasa Open Source version where the readers / writer don't have the switch. |
I think the docs look okay, @degiz what would you add to clarify further? |
@erohmensing I don't have anything specific on mind, just wanted anyone from CSE to confirm 👍 |
@edmacovaz what do you think about the Rasa X implications? |
@edmacovaz Have you seen my comment above? |
@wochinge Sorry, I missed that one. I'll try to find some time to think about this once the squad organisation stuff has settled a little. I guess this still falls with you and the Enable team (where I think there's an open question about where you get your design help from). Does that work for you? |
Mhm, could also be the CDD squad 🤔 Works for me 👍🏻 |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)