Support server list, drop group_id from producer #7439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-quachtran
approved these changes
Dec 3, 2020
|
@b-quachtran does this do the same as your PR? |
|
@b-quachtran what should we do with this PR now? Did the other PR cover this already? |
|
@akelad My PR didn't include support for server list and I removed the ready-to-merge status because of some failed CI checks, but that looks resolved now. |
|
is the support server list actually a request from a customer? Because we shouldn't really be merging new features into patch releases |
|
also the changelog entry needs to be changed, some of the stuff listed in there is not part of this PR |
|
@akelad Yeah, a customer specifically asked about adding multiple Kafka server support in 1.10.X |
|
@b-quachtran will you take care of doing a minor release then? |
|
@akelad Yep, definitely. I'll take care of the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)