Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed changing fingerprints even though training data did not change #7246

Merged
merged 7 commits into from
Nov 13, 2020
Merged

Fixed changing fingerprints even though training data did not change #7246

merged 7 commits into from
Nov 13, 2020

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Nov 11, 2020 •
edited
Loading

Issue:

  • we relied on hashes in some places to fingerprint parts of the configuration / training data. hashes of strings are not stable across python (>3.3) runs, which means that the fingerprint changes even though the configuration / data is still the same

Proposed changes:

  • implement proper fingerprinting using md5 for strings instead of python native hashes

Status (please check what you already did):

  • added some tests for the functionality
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tmbo tmbo requested review from a team and alwx and removed request for a team November 11, 2020 17:40
tmbo
tmbo commented Nov 12, 2020
View reviewed changes
tests/utils/test_io.py Outdated Show resolved Hide resolved
alwx
alwx reviewed Nov 12, 2020
View reviewed changes
rasa/shared/utils/io.py Outdated Show resolved Hide resolved
alwx
alwx approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@alwx alwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@rasabot rasabot merged commit b3bfab6 into master Nov 13, 2020
@rasabot rasabot deleted the fix-fingerprints branch November 13, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alwx alwx alwx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmbo @alwx @rasabot