Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require slack signing secret #7204

Merged
merged 13 commits into from
Nov 16, 2020
Merged

Require slack signing secret #7204

merged 13 commits into from
Nov 16, 2020

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Nov 8, 2020

Proposed changes:

  • Require slack signing secret
  • renamed and moved InvalidConfigurationError

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tmbo tmbo requested review from a team, alwx and wochinge and removed request for a team November 8, 2020 16:10
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

changelog/7204.bugfix.md Outdated Show resolved Hide resolved
rasa/core/channels/slack.py Outdated Show resolved Hide resolved
rasa/nlu/components.py Outdated Show resolved Hide resolved
rasa/nlu/components.py Show resolved Hide resolved
rasa/shared/exceptions.py Show resolved Hide resolved
@tmbo
Copy link
Member Author

tmbo commented Nov 15, 2020

@tczekajlo is there a way to tell the security check that these secrets are ok and not an issue?

@virtualroot
Copy link
Contributor

@tmbo You can configure gitleaks to ignore the file if you add it into the allowlist section https://github.com/RasaHQ/rasa/blob/master/.gitleaks.toml#L107

@tczekajlo
Copy link
Contributor

tczekajlo commented Nov 16, 2020

@tczekajlo is there a way to tell the security check that these secrets are ok and not an issue?

@tmbo Yes, there is the .gitleaks.toml file with the configuration for the gitleaks. I've added extra configuration that should help with your issue and similar in the future.

@tmbo
Copy link
Member Author

tmbo commented Nov 16, 2020

perfect, thanks a lot 🚀

@tmbo tmbo merged commit 0ccfa20 into master Nov 16, 2020
@tmbo tmbo deleted the slack-remove-deprecation branch November 16, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants