Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt the training data reader and emulator for DialogFlow to their latest format #7160

Merged
merged 17 commits into from
Nov 5, 2020
Merged

Adapt the training data reader and emulator for DialogFlow to their latest format #7160

merged 17 commits into from
Nov 5, 2020

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Nov 2, 2020 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx changed the base branch from master to luis-training-data November 2, 2020 16:03
@alwx alwx force-pushed the dialogflow-training-data branch from 7063996 to 34ddba2 Compare November 3, 2020 09:09
@alwx alwx requested a review from wochinge November 3, 2020 09:09
@alwx alwx marked this pull request as ready for review November 3, 2020 09:09
@alwx alwx requested a review from a team November 3, 2020 09:09
wochinge
wochinge reviewed Nov 3, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Looks very good - some small questions for the emulator then we are ready to go 🚀

changelog/7160.improvement.md Outdated Show resolved Hide resolved
data/examples/dialogflow/intents/inform.json Show resolved Hide resolved
rasa/nlu/emulators/dialogflow.py Outdated Show resolved Hide resolved
rasa/nlu/emulators/dialogflow.py Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/dialogflow.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/dialogflow.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/dialogflow.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/dialogflow.py Outdated Show resolved Hide resolved
rasa/shared/nlu/training_data/formats/dialogflow.py Outdated Show resolved Hide resolved
@alwx alwx force-pushed the dialogflow-training-data branch from 2eb24f0 to d21cf92 Compare November 3, 2020 16:00
@alwx alwx requested a review from wochinge November 3, 2020 16:13
wochinge
wochinge reviewed Nov 4, 2020
View reviewed changes
changelog/7160.improvement.md Outdated Show resolved Hide resolved
docs/docs/migrate-from/google-dialogflow-to-rasa.mdx Outdated Show resolved Hide resolved
tests/nlu/emulators/test_dialogflow.py Outdated Show resolved Hide resolved
tests/nlu/emulators/test_dialogflow.py Outdated Show resolved Hide resolved
@alwx alwx requested a review from wochinge November 4, 2020 12:46
wochinge
wochinge approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks! Great reverse engineering 💪

docs/docs/migrate-from/google-dialogflow-to-rasa.mdx Outdated Show resolved Hide resolved
@alwx alwx force-pushed the dialogflow-training-data branch from 05f4d2c to bb4496b Compare November 5, 2020 09:59
Base automatically changed from luis-training-data to master November 5, 2020 10:18
@alwx alwx force-pushed the dialogflow-training-data branch from bb4496b to 2a40893 Compare November 5, 2020 10:19
@rasabot rasabot merged commit 26884fe into master Nov 5, 2020
@rasabot rasabot deleted the dialogflow-training-data branch November 5, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alwx @wochinge @rasabot