Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing metadata key in rule schema #7090

Merged
merged 2 commits into from
Oct 27, 2020
Merged

add missing metadata key in rule schema #7090

merged 2 commits into from
Oct 27, 2020

Conversation

pheel
Copy link
Contributor

@pheel pheel commented Oct 22, 2020 •
edited
Loading

Proposed changes:
Previously, stories allowed for a metadata key, but not rules.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger sara-tagger requested a review from amn41 October 23, 2020 06:00
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @amn41 will take a look at it as soon as possible ✨

tmbo
tmbo approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this change to the yaml schema 🚀

@tmbo tmbo merged commit f65cfce into RasaHQ:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

@amn41 amn41 Awaiting requested review from amn41

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pheel @sara-tagger @tmbo