Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various sentry errors #7057

Merged
merged 15 commits into from
Oct 22, 2020
Merged

Fix various sentry errors #7057

merged 15 commits into from
Oct 22, 2020

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Oct 19, 2020

Proposed changes:

  • fixes several sentry errors, one per commit, so probably easiest to review per commit
  • add telemetry context to sentries reported exceptions 85263f0

Included fixes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tmbo
Copy link
Member Author

tmbo commented Oct 19, 2020

the only one changing user behaviour is c658aa8

@tmbo tmbo force-pushed the fix-sentry-errors branch from 76c4588 to 7cb41f3 Compare October 19, 2020 21:26
@tmbo tmbo requested a review from federicotdn October 20, 2020 07:41
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only added small comments.

changelog/7057.misc.md Outdated Show resolved Hide resolved
rasa/nlu/components.py Show resolved Hide resolved
rasa/telemetry.py Outdated Show resolved Hide resolved
tests/nlu/test_components.py Outdated Show resolved Hide resolved
@tmbo tmbo changed the base branch from master to 2.0.x October 21, 2020 11:17
@tmbo tmbo changed the base branch from 2.0.x to master October 21, 2020 11:19
@tmbo tmbo force-pushed the fix-sentry-errors branch from 3c23d75 to 6c9c895 Compare October 21, 2020 11:40
@tmbo tmbo changed the base branch from master to 2.0.x October 21, 2020 11:41
@tmbo tmbo merged commit abdab47 into 2.0.x Oct 22, 2020
@tmbo tmbo deleted the fix-sentry-errors branch October 22, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment