Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for 2.0.0a3 and implementation disagree on how forms are described in domain #6535

Closed
federicotdn opened this issue Sep 1, 2020 · 2 comments · Fixed by #6594
Closed
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones.

Comments

@federicotdn
Copy link
Contributor

federicotdn commented Sep 1, 2020

Tested on Rasa 2.0.0a3.

There might be a problem with how forms are defined in the domain in Rasa 2.0.0. The documentation shows the following example:

forms:
  your_form:
    age:
    - type: from_entity
      entity: age

But if I try using that, it fails with:

2020-09-01 14:44:47 ERROR    pykwalify.core  - validation.invalid
2020-09-01 14:44:47 ERROR    pykwalify.core  -  --- All found errors ---
2020-09-01 14:44:47 ERROR    pykwalify.core  - ["Value '{'your_form': {'age': [{'type': 'from_entity', 'entity': 'age'}]}}' is not a list. Value path: '/forms'"]

However changing forms from a map to a list of objects works:

forms:
- your_form:
    age:
    - type: from_entity
      entity: age

It is not clear if the implementation is correct, or the docs. The schema described by the docs is easier to handle and use programmatically.

@federicotdn federicotdn added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. labels Sep 1, 2020
@federicotdn federicotdn added this to the 2.0rc1 Rasa Open Source milestone Sep 1, 2020
@wochinge
Copy link
Contributor

wochinge commented Sep 3, 2020

@federicotdn Do you want to keep it in the loop? ProdSquad worked on this as part of rules.

@federicotdn
Copy link
Contributor Author

Not necessary! Feel free to move it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants