Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise proper user warnings for backwards compatibility code #6487

Closed
m-vdb opened this issue Aug 26, 2020 · 5 comments · Fixed by #9187
Closed

Raise proper user warnings for backwards compatibility code #6487

m-vdb opened this issue Aug 26, 2020 · 5 comments · Fixed by #9187
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@m-vdb
Copy link
Collaborator

m-vdb commented Aug 26, 2020

(Original slack thread)

Looking for "compatibility" in the codebase shows several examples of code that are still here for backwards compatibility purposes (until when?) but the users are not warned about them. If possible, we should introduced warnings for each of these communicate that they'll be removed in Rasa 3.0

List of things to address:

@m-vdb m-vdb added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Aug 26, 2020
@stale
Copy link

stale bot commented Dec 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 4, 2020
@m-vdb m-vdb removed the stale label Dec 7, 2020
@wochinge
Copy link
Contributor

@m-vdb I remember you did some changes for this - can this issue be closed?

@m-vdb
Copy link
Collaborator Author

m-vdb commented Jan 27, 2021

no I haven't done anything for this. If you search "compatibility" in all the python files, you'll see examples of code that is backwards compatible, but it's not clear if some of these should actually be deprecated. My reasoning is that we can only keep backward compatibility for so long, so we might as well tell users things are deprecated as soon as we can? What do you think?

@wochinge
Copy link
Contributor

wochinge commented Feb 2, 2021

Fully agree 👍🏻

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@m-vdb m-vdb removed the stale label Jul 21, 2021
@m-vdb m-vdb self-assigned this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants