Correct path for Poetry cached libraries on Windows #6403
Conversation
alwx
changed the title
|
@alwx i've re-run the build to see if the cache is picked up (because I didn't see it in the last build) |
|
It doesn't look like it's loading the cache :/ |
|
It took a while to finish it, but now cache works for both Windows and Ubuntu! |
| @@ -95,10 +95,10 @@ pika = "~1.1.0" | |||
| jsonschema = "~3.2" | |||
| packaging = ">=20.0,<21.0" | |||
| pytz = ">=2019.1,<2021.0" | |||
| rasa-sdk = "^2.0.0a4" | |||
| rasa-sdk = "^2.0.0a5" | |||
There was a problem hiding this comment.
why do we need to change that?
There was a problem hiding this comment.
I updated sanic in the latest version of rasa-sdk, and the new version of sanic has better Windows support. We had a discussion about it while you were on vacation :)
There was a problem hiding this comment.
I saw it but wouldn't it automatically pick the latest sdk version and latest sanic version (without changing the minimal alpha version)?
|
|
||
| from rasa.core.training.converters.story_markdown_to_yaml_converter import ( | ||
| StoryMarkdownToYamlConverter, | ||
| ) | ||
| from rasa.shared.constants import LATEST_TRAINING_DATA_FORMAT_VERSION | ||
|
|
||
|
|
||
| @pytest.yield_fixture(scope="session") | ||
| def event_loop(request: Request) -> Iterator[asyncio.AbstractEventLoop]: |
There was a problem hiding this comment.
why is this needed? If the scope is session it should go into conftest imo. If this just for the module, then the scope should be module
| key: ${{ runner.os }}-poetry-${{ matrix.python-version }}-${{ hashFiles('**/poetry.lock') }} | ||
| restore-keys: ${{ runner.os }}-poetry-${{ matrix.python-version }} | ||
| path: .venv | ||
| key: ${{ runner.os }}-poetry-${{ matrix.python-version }}-${{ hashFiles('**/poetry.lock') }}-4 |
There was a problem hiding this comment.
Oh that's a mistake (just because I was testing cache, will update in a sec)
| @@ -95,10 +95,10 @@ pika = "~1.1.0" | |||
| jsonschema = "~3.2" | |||
| packaging = ">=20.0,<21.0" | |||
| pytz = ">=2019.1,<2021.0" | |||
| rasa-sdk = "^2.0.0a4" | |||
| rasa-sdk = "^2.0.0a5" | |||
There was a problem hiding this comment.
I saw it but wouldn't it automatically pick the latest sdk version and latest sanic version (without changing the minimal alpha version)?
| # the project itself, which also makes it easier for us to determine the correct directory | ||
| # that needs to be cached. | ||
| run: | | ||
| poetry config virtualenvs.in-project true |
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)