-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permission errors during export are not handled in interactive training #5921
Comments
@Dobatymo Why is the permission error happening in the first place? |
It mostly happens when multiple people are working on the same chatbot repository. Then to fix, we would run chmod on the story/domain/nlu files and redo the training. With my pull request, we can run chmod when we encounter the error and try exporting again, so we don't lose any training data. |
Phew. I think this is an error which is very specific to your use case and should be handled within your infrastructure and not within Rasa Open Source. E.g. you could make the files readable by the group and have all users be part of the same group. |
I already fixed the problem with a different set of permissions. But I still think handling PermissionErrors (and probably other kinds of OSErrors) is a useful and expected feature. When my text editor cannot save a file, I expect it to ask me to retry instead of crash. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I changed to pull request to handle all OSErrors to catch other IO errors like full disk for example. I think these kind of errors should be handled, as they would be with other text editors. |
Sorry @Dobatymo, the notifications for your previous message somehow slipped through the cracks. Will give your PR a review 👍 |
Rasa version:1.10.0
Python version: 3.7.4
Operating system: Windows
Issue:
If writing the exported data from interactive training (stories, nlu, domain using "Export and quit") raises a PermissionError, the training data is lost. I will attach a pull request which catches the error and asks for user interaction.
PR: #5922
The text was updated successfully, but these errors were encountered: