Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiProjectImporter should ignore tests directory in imported projects #5913

Closed
3 tasks done
kevinthenet opened this issue May 28, 2020 · 3 comments · Fixed by #5951
Closed
3 tasks done

MultiProjectImporter should ignore tests directory in imported projects #5913

kevinthenet opened this issue May 28, 2020 · 3 comments · Fixed by #5951
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@kevinthenet
Copy link
Contributor

kevinthenet commented May 28, 2020

Description of Problem:

I was in the process of testing out the MultiProjectImporter for use in my own projects (which I love), so I set up two nested directories using rasa init:

├── actions.py
├── config.yml
├── data
│   ├── mood_1_nlu.md
│   └── mood_1_stories.md
├── domain.yml
├── models
│   └── 20200528-101144.tar.gz
├── projects
   └── Mood2Bot
       ├── config.yml
       ├── data
       │   ├── mood_2_nlu.md
       │   └── mood_2_stories.md
       ├── tests
       │   └── conversation_tests.md
       └── domain.yml

This lead to log messages like these:

UserWarning: Found unknown intent 'bot_challenge: are you a bot?' on line 50. Please, make sure that all intents are listed in your domain yaml.
2020-05-28 10:24:57 WARNING  rasa.core.featurizers  - Feature 'intent_bot_challenge: are you a bot?' could not be found in feature map.

I believe this is the function causing this issue.

Overview of the Solution:

Ignore the tests/ directory in an imported project, since this format is not for training, as specified in the docs. Just as well, it promotes isolated, project-level conversation testing, which seems to be the goal of this feature.

Examples (if relevant):

Blockers (if relevant):

Definition of Done:

  • Add test for tests/ in imported project
  • Ignore tests/ directory when walking the project directory
  • Document changes in change log
@kevinthenet kevinthenet added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels May 28, 2020
@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀 @Ghostvv will get back to you about it soon! ✨

@wochinge
Copy link
Contributor

wochinge commented Jun 2, 2020

good catch, @ortsaCniveK 🎉 Do you wanna implement a fix for this? I'd be available for feedback and help. Otherwise we'd add it to our backlog.

@kevinthenet
Copy link
Contributor Author

I can work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants