Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token_pattern is incorrectly applied on incoming text during inference #5905

Closed
dakshvar22 opened this issue May 27, 2020 · 0 comments · Fixed by #6073
Closed

Token_pattern is incorrectly applied on incoming text during inference #5905

dakshvar22 opened this issue May 27, 2020 · 0 comments · Fixed by #6073
Assignees
@tabergma
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@dakshvar22
Copy link
Contributor

Rasa version: 1.10.0

Python version: 3.6.5

Operating system (windows, osx, ...): MacOS

Issue: The original problem is explained here. It is not a quick fix because since we use sequence in our downstream models, we cannot alter the length of the sequence in a featurizer. Hence, token_pattern should be added as a parameter inside a tokenizer and removed from countvectorsfeaturizer.
@dakshvar22 dakshvar22 added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels May 27, 2020
@tabergma tabergma self-assigned this Jun 26, 2020
@tabergma tabergma mentioned this issue Jun 26, 2020
Merged
4 tasks
@tabergma tabergma mentioned this issue Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabergma tabergma

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move token_pattern to tokenizers RasaHQ/rasa
2 participants
@tabergma @dakshvar22