Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in 'ensure_consistent_bilou_tagging' #5825

Merged
merged 3 commits into from
May 15, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented May 14, 2020

Proposed changes:

  • Fix error in ensure_consistent_bilou_tagging.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from akelad May 14, 2020 13:57
logger.debug(
"Inconsistent BILOU tagging found, B- tag not closed by L- tag, "
"i.e [B-a, I-a, O] instead of [B-a, L-a, O].\n"
"Assuming last tag is L- instead of I-."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tabergma in what type of situations does this actually happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRFEntityExtractor or DIETClassifier may predict inconsistent BILOU tags.

@akelad
Copy link
Contributor

akelad commented May 15, 2020

thanks for the fix :D should we release a patch directly?

@tabergma tabergma merged commit ec4a2b1 into 1.10.x May 15, 2020
@tabergma
Copy link
Contributor Author

yes, that was my plan, will do a patch release now

@tabergma tabergma deleted the fix-ensure-consistent-bilou-tagging branch May 15, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants