Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise warning if entities are not correctly annotated. #5672

Merged
merged 6 commits into from
Apr 22, 2020
Merged

Raise warning if entities are not correctly annotated. #5672

merged 6 commits into from
Apr 22, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Apr 20, 2020 •
edited
Loading

Proposed changes:

  • Check entities are correctly annotated in the training data.

part of https://github.com/RasaHQ/research/issues/87

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from dakshvar22 April 20, 2020 13:25
@tabergma tabergma force-pushed the consistent-entity-annotations branch from f24b765 to aef9cf6 Compare April 20, 2020 13:28
dakshvar22
dakshvar22 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one optional comment.

changelog/5672.improvement.rst Outdated Show resolved Hide resolved
@tabergma tabergma merged commit b8f0255 into composite-entities Apr 22, 2020
@tabergma tabergma deleted the consistent-entity-annotations branch April 22, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakshvar22 dakshvar22 dakshvar22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabergma @dakshvar22