Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter grads #5669

Merged
merged 20 commits into from
Apr 23, 2020
Merged

Filter grads #5669

merged 20 commits into from
Apr 23, 2020

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Apr 20, 2020 •
edited
Loading

Proposed changes:

  • remove regularization gradient for variables that don't have prediction gradient

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Ghostvv Ghostvv requested review from tabergma and dakshvar22 April 20, 2020 08:20
@Ghostvv
Copy link
Contributor Author

Ghostvv commented Apr 20, 2020

should be merged after #5636

tabergma
tabergma approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Ghostvv Ghostvv merged commit e456f78 into master Apr 23, 2020
@Ghostvv Ghostvv deleted the filter-grads branch April 23, 2020 12:31
@dakshvar22 dakshvar22 mentioned this pull request Oct 13, 2021
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

@dakshvar22 dakshvar22 Awaiting requested review from dakshvar22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ghostvv @tabergma