Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update POST /model/train endpoint to accept responses #5595

Merged
merged 5 commits into from
Apr 9, 2020

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Apr 8, 2020

Proposed changes:

  • Update POST /model/train endpoint to accept responses

This change is required to train models while using retrieval intents in Rasa X.

Status (please check what you already did):

  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx force-pushed the train-retrieval-intents branch from 3b74ec4 to a951290 Compare April 8, 2020 10:29
@alwx alwx force-pushed the train-retrieval-intents branch from a951290 to d9b923d Compare April 8, 2020 10:30
@alwx alwx requested a review from ricwo April 8, 2020 10:30
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 Left a few minor comments

changelog/5595.improvement.rst Outdated Show resolved Hide resolved
docs/_static/spec/rasa.yml Outdated Show resolved Hide resolved
docs/_static/spec/rasa.yml Outdated Show resolved Hide resolved
docs/_static/spec/rasa.yml Outdated Show resolved Hide resolved
docs/_static/spec/rasa.yml Outdated Show resolved Hide resolved
rasa/server.py Show resolved Hide resolved
@alwx alwx merged commit ef3ae7c into master Apr 9, 2020
@tmbo tmbo deleted the train-retrieval-intents branch May 1, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants