Implemented get_output_channel() fn for SocketIO Channel

[alfredfrancis]

Proposed changes:

• Implemented get_output_channel() fn for SocketIO Channel
• Changed Socketio Output message handlers to use recepient_id instead of self.sid

Status (please check what you already did):

• added some tests for the functionality
• updated the documentation
• updated the changelog (please check changelog for instructions)
• reformat files using black (please check Readme for instructions)

[CLAassistant]

All committers have signed the CLA.

[sara-tagger]

Thanks for submitting a pull request 🚀 @erohmensing will take a look at it as soon as possible ✨

[sara-tagger]

Thanks for submitting a pull request 🚀 @degiz will take a look at it as soon as possible ✨

[chkoss]

Here is some context as to why this feature was implemented: https://forum.rasa.com/t/integrate-rasa-with-live-chat/22314/6

[degiz]

Thanks for the PR! 👌

I've added few comments. Also, do you think we can have a unit test for that change?

@wochinge could you take a look as well? I know you had some concerns. I've tested that change locally and it seems to work ok. What I tried:

• Create two conversation in different browsers
• Inject intents via REST to both conversations, and both did received responses

[wochinge]

Thanks for pulling me in @degiz .
Cool work @alfredfrancis . I didn't know that socketio handles a mapping from sid to socket in the background 💯 🚀

To be honest. I am still not entirely convinced since this won't work with multiple Rasa Open Source instances or in case we are using multiple Sanic workers (the latter is not the case at the moment). However, since it probably covers 90% of all use cases, I'm fine with merging it.

• let's add a note that this only works with a single Rasa Open Source instance
• We should also update the API spec here that Socketio works now

  rasa/docs/_static/spec/rasa.yml

  Line 829 in 2edc18a

  - latest

[m-vdb]

@wochinge @alfredfrancis 💡 Rasa Open Source release is scheduled for next Tuesday April 28th. Any chance we can ship this as part of the milestone?

[alfredfrancis]

@wochinge @alfredfrancis Rasa Open Source release is scheduled for next Tuesday April 28th. Any chance we can ship this as part of the milestone?

I'm waiting for the comments from @wochinge

[wochinge]

@alfredfrancis I have to do another review first, then I'm back on this 👍

[wochinge]

Great work @alfredcogniwide 🎉 Left two small comments, but otherwise ready to go.
Can you please make sure that the CI tests here pass https://github.com/RasaHQ/rasa/actions/runs/81645737 ? If any results there are wrong, please let me know. We / GitHub recently had some problems with GitHub actions 😞

[alfredfrancis]

Great work @alfredcogniwide Left two small comments, but otherwise ready to go.
Can you please make sure that the CI tests here pass https://github.com/RasaHQ/rasa/actions/runs/81645737 ? If any results there are wrong, please let me know. We / GitHub recently had some problems with GitHub actions

Ok, let me try

[wochinge]

@alfredfrancis Can you please also add a changelog entry? 🙏

[wochinge]

@alfredfrancis Could you please also sign the CLA? Thanks 🎉

[alfredfrancis]

@alfredfrancis Can you please also add a changelog entry?

Could you help me do this ? Shall I add an entry under [1.9.7] - 2020-04-23

[wochinge]

Awesome! I quickly added changelog and a small docs change, because we want to include this in the release today 🎉

code changed

[wochinge]

Thanks for the contribution @alfredfrancis 🙏

[alfredfrancis]

Awesome! I quickly added changelog and a small docs change, because we want to include this in the release today

Thank you

[alfredfrancis]

Thanks for the contribution @alfredfrancis

You are most welcome ❤️