Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_number_of_predictions parameter not considered during story testing #5489

Closed
akelad opened this issue Mar 25, 2020 · 0 comments · Fixed by #5545
Closed

max_number_of_predictions parameter not considered during story testing #5489

akelad opened this issue Mar 25, 2020 · 0 comments · Fixed by #5545
Assignees
Labels
type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@akelad
Copy link
Contributor

akelad commented Mar 25, 2020

When running rasa test, during story evaluation it seems like the max_number_of_predictions parameter in the processor isn't taken into account. This means if there's stories with a lot of actions in a row (>10 by the default parameter), the tests will pass, but when a user talks to the bot the circuit breaker will be tripped.

During action prediction when talking to the bot, the _predict_and_execute_next_action function in the processor gets executed, whereas during the test it's the predict_next_action function.

We should make it so that the predict_next_action function also takes the max_number_of_predictions parameter into account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants