-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return scale loss #5482
return scale loss #5482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good!
Also, I think we should add a changelog entry. |
@tabergma I updated changelog and changed the logic of scaling loss: now it only turns on, if at least 1 example in a batch is learned (making training loss curve jump to higher values after some epoch) don't know what to do with |
DeepSource checks the complete file you touched. If the checks are not critical, I guess you can ignore them for now. I think we are fine here. But ideally all of them are tackled. |
Proposed changes:
0.5
Status (please check what you already did):
black
(please check Readme for instructions)