-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No session start when appending events via API #5446
Conversation
@ricwo Could you please have a short look? This will fix some behavior in Rasa X interactive learning (part of https://github.com/RasaHQ/rasa-x/issues/2023 ) . And another thing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great so far 👍
I checked it out. The session start events are still correctly attached in rasa interactive
Yes rasa interactive
uses GET /tracker
which fetches the tracker with the session start sequence
rasa/core/processor.py
Outdated
def get_tracker(self, conversation_id: Text) -> Optional[DialogueStateTracker]: | ||
"""Get the tracker for a conversation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make this a processor
method, so the contrast with get_tracker_with_session_start()
is more apparent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhm, it's already a processor
method? I could move it up so that they are right next to each other?
Co-Authored-By: ricwo <[email protected]>
Co-Authored-By: ricwo <[email protected]>
00b8a79
to
6ba8d86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Co-Authored-By: ricwo <[email protected]>
…HQ/rasa into append-events-without-session-start
Proposed changes:
/conversations/<conversation_id>/execute
since this part is heavily used byrasa interactive
Status (please check what you already did):
black
(please check Readme for instructions)