Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reminderbot demo and add user guide #5189

Merged
merged 31 commits into from
Feb 25, 2020
Merged

Implement reminderbot demo and add user guide #5189

merged 31 commits into from
Feb 25, 2020

Conversation

JEM-Mosig
Copy link

@JEM-Mosig JEM-Mosig commented Feb 4, 2020 •
edited
Loading

Proposed changes:

  • Write a user-guide for reminders and external events
  • Add another example bot: reminderbot

Status (please check what you already did):

  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@JEM-Mosig JEM-Mosig self-assigned this Feb 4, 2020
@JEM-Mosig JEM-Mosig requested a review from erohmensing February 6, 2020 12:59
@JEM-Mosig JEM-Mosig marked this pull request as ready for review February 6, 2020 12:59
@JEM-Mosig JEM-Mosig requested a review from wochinge February 6, 2020 12:59
@JEM-Mosig JEM-Mosig changed the title Implement reminderbot demo Implement reminderbot demo and user guide Feb 6, 2020
@JEM-Mosig JEM-Mosig changed the title Implement reminderbot demo and user guide Implement reminderbot demo and add user guide Feb 6, 2020
@JEM-Mosig
Copy link
Author

@erohmensing How should I mention the new demo bot in the change log? Is it a doc or an improvement?

erohmensing
erohmensing reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think having this under documentation in the changelog is fine 👍

changelog/5189.doc.rst Show resolved Hide resolved
docs/core/responses.rst Outdated Show resolved Hide resolved
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
docs/core/responses.rst Outdated Show resolved Hide resolved
examples/reminderbot/actions.py Outdated Show resolved Hide resolved
examples/reminderbot/actions.py Show resolved Hide resolved
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
examples/reminderbot/actions.py Outdated Show resolved Hide resolved
wochinge
wochinge reviewed Feb 12, 2020
View reviewed changes
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
examples/reminderbot/actions.py Outdated Show resolved Hide resolved
examples/reminderbot/actions.py Outdated Show resolved Hide resolved
examples/reminderbot/actions.py Outdated Show resolved Hide resolved
examples/reminderbot/actions.py Outdated Show resolved Hide resolved
examples/reminderbot/actions.py Outdated Show resolved Hide resolved
@erohmensing
Copy link
Contributor

IMO this is just new documentation, not a new feature -- can we put it on the .x branch so that people know how to use the updated feature?

@JEM-Mosig JEM-Mosig mentioned this pull request Feb 17, 2020
Closed
@JEM-Mosig
Copy link
Author

JEM-Mosig commented Feb 21, 2020 •
edited
Loading

IMO this is just new documentation, not a new feature -- can we put it on the .x branch so that people know how to use the updated feature?

I can rebase it. Though the next release is in a few days anyway...

@erohmensing
Copy link
Contributor

yeah, at this point, if the rebase is a bitch, i think master is fine as long as it goes in before the release

wochinge
wochinge approved these changes Feb 24, 2020
View reviewed changes
docs/user-guide/reminders-and-external-events.rst Outdated Show resolved Hide resolved
examples/reminderbot/credentials.yml Outdated Show resolved Hide resolved
examples/reminderbot/credentials.yml Outdated Show resolved Hide resolved
examples/reminderbot/credentials.yml Outdated Show resolved Hide resolved
examples/reminderbot/README.md Outdated Show resolved Hide resolved
examples/reminderbot/README.md Outdated Show resolved Hide resolved
examples/reminderbot/credentials.yml Show resolved Hide resolved
docs/core/reminders-and-external-events.rst Outdated Show resolved Hide resolved
docs/core/reminders-and-external-events.rst Outdated Show resolved Hide resolved
docs/core/reminders-and-external-events.rst Outdated Show resolved Hide resolved
@erohmensing erohmensing added this to the Rasa 1.8 milestone Feb 24, 2020
@JEM-Mosig JEM-Mosig merged commit 00143ae into master Feb 25, 2020
@JEM-Mosig JEM-Mosig deleted the johannes-reminder-demo branch February 25, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing left review comments

@wochinge wochinge wochinge approved these changes

@tmbo tmbo tmbo left review comments

Assignees

@JEM-Mosig JEM-Mosig

Labels
None yet
Projects
None yet
Milestone
Rasa 1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@JEM-Mosig @erohmensing @tmbo @wochinge