-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include story source filename in core output for failed stories #3419
Comments
Hi @erohmensing |
Cool, I will assign you! Awesome that you're taking this on :) just ping me if you have questions. |
Hey @lmaczulajtys, are you still working on this? Let me know if you need any pointers :) |
Hi @erohmensing, I'll submit PR in two days. Sorry it took so long. Hard time at work. |
No worries. Looking forward to your contribution! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @erohmensing , I want to try this one. Any requirements on the output of the
|
Sure! I'd go with relative path though. Maybe something like
I'll assign you to it. Let me know if you have any other questions :) |
I already looked in to it and a relative path does not seem possible. At the start of the process the stories are copied to a temporary directory and prefixed with a unique id. So probably the best will be:
If you use same story filenames in different folders it will still be hard to tell in which file it is. I still need to figure out how to pass the file name to the output for the failed stories. |
interesting edge case! i hadn't even thought about that.
|
Files look like |
Include story source filename in the story name in the failed stories output to help find the failed story more easily (see RasaHQ#3419). Passed the source filename starting from the `StoryFileReader` to a `StoryStep`. Besides the story block names the source filename is included in the tracker events which are used for outputting the failed stories. Because the story files are copied to a temporary folder it is not possible to include the original full story path.Instead only the file name is included. If a recursive folder structure is used with the same story file names it can still be hard to find the problem file.
I've submitted a PR. It is based on the previous PR of @lmaczulajtys but taken into account the review comment that was made. |
Include story source filename in the story name in the failed stories output to help find the failed story more easily (see RasaHQ#3419). Passed the source filename starting from the `StoryFileReader` to a `StoryStep`. Besides the story block names the source filename is included in the tracker events which are used for outputting the failed stories. Because the story files are copied to a temporary folder it is not possible to include the original full story path.Instead only the file name is included. If a recursive folder structure is used with the same story file names it can still be hard to find the problem file.
closed by #5496 |
If I have multiple story files like our demobot does, it would help me find the story more easily if above the story name it told me which story file it came from, since my stories might have same names in different files.
The text was updated successfully, but these errors were encountered: